Difference between revisions of "Review/Process"
(Created page with "New code with major additions must run through a [http://www.boost.org/community/reviews.html Boost Review cycle]. It is suggested that you post to the [http://forum.dlang.org...") |
He the great (talk | contribs) (Adding rights and responsibilities) |
||
| Line 4: | Line 4: | ||
Smaller additions such as expanding existing functionality or fixing bugs can skip the formal review process. Remember that it is volunteers running this which means pull requests could have long waiting periods before getting reviewed. You can use the newsgroups to peek more interest in the request. | Smaller additions such as expanding existing functionality or fixing bugs can skip the formal review process. Remember that it is volunteers running this which means pull requests could have long waiting periods before getting reviewed. You can use the newsgroups to peek more interest in the request. | ||
| + | |||
| + | Note that we have similar expectations for [http://www.boost.org/community/reviews.html#Maintainer Library Maintainer's Rights and Responsibilities]. As the size of Phobos grows it is important the support team also grows. Actively monitoring the newsgroup/mailing list for discussions of your module is not required however it is important that you are reachable and available for inquires if a separate maintainer was not appointed. | ||
[[Review Queue]] | [[Review Queue]] | ||
Revision as of 04:27, 4 April 2013
New code with major additions must run through a Boost Review cycle. It is suggested that you post to the Development Newsgroup to gauge interest and identify it isn't already being worked on. Don't get discouraged from low response as this can be for several reasons, but hopefully a sign that others agree it should be in Phobos will comment. And even if it is decided not to fit, if it is code you are interest in having others are likely too and can be its own library.
The process is a standard three weeks once the code is ready. Two weeks are left for review of the source and API, and is followed by a week of voting. During the review the code can be modified to appease the criticism, and it will be up to the submitter and review manager to decide if it makes sense to continue with a vote or postpone for a later review.
Smaller additions such as expanding existing functionality or fixing bugs can skip the formal review process. Remember that it is volunteers running this which means pull requests could have long waiting periods before getting reviewed. You can use the newsgroups to peek more interest in the request.
Note that we have similar expectations for Library Maintainer's Rights and Responsibilities. As the size of Phobos grows it is important the support team also grows. Actively monitoring the newsgroup/mailing list for discussions of your module is not required however it is important that you are reachable and available for inquires if a separate maintainer was not appointed.
